Skip to content

fix: include types check to package.json exports to fix recent typescript export issues #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

helgardferreira
Copy link
Contributor

@helgardferreira helgardferreira commented Jul 28, 2023

A recent issue that has arisen for various libraries that also impacts the build of this project can be found here: microsoft/TypeScript#52363

This PR adds a quick fix to the package.json to help alleviate the issue.

P.S. This library is a god-send. I've wasted hours upon hours trying to figure out a sane Vite + TypeScript + Tailwind setup and this just works. Thank you so much!

@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vite-component-library-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 1:30am

Copy link
Owner

@IgnacioNMiranda IgnacioNMiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @helgardferreira! I wasn't aware of this issue. LGTM 🙂 and thanks for your words, really glad to know that this is being helpful!

@IgnacioNMiranda IgnacioNMiranda merged commit 432f5cb into IgnacioNMiranda:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants