Skip to content

imports cleanup #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2021
Merged

imports cleanup #221

merged 4 commits into from
Apr 20, 2021

Conversation

fredrikt
Copy link
Contributor

use absolute imports and clean out unused imports

fredrikt added 4 commits April 20, 2021 15:54
@fredrikt
make all imports absolute and remove unused ones
410de21
@fredrikt
add missing import of NS
bcd848e
@fredrikt
additional cleanups
28478f9
@fredrikt
with all imports absolute, pytest --import-mode=importlib works
2d775e4 
importlib is a more robust mechanism for test discovery, which is
indended to become the default in a future version of pytest
@fredrikt fredrikt requested a review from leifj April 20, 2021 14:15
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 72.083% when pulling 2d775e4 on ft-imports_cleanup into 2ef05de on master.

leifj
leifj requested changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@leifj leifj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nånting pajjar i 3.7 nu

@leifj leifj merged commit 767a0b2 into master Apr 20, 2021
@leifj leifj deleted the ft-imports_cleanup branch April 20, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leifj leifj leifj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikt @coveralls @leifj