Enhance Context object properties #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peppelinux would you like to verify that this works as expected? |
peppelinux
reviewed
Aug 27, 2021
| @@ -128,6 +128,7 @@ def __call__(self, environ, start_response, debug=False): | |||
| context.request_uri = environ.get("REQUEST_URI") | |||
| context.request_method = environ.get("REQUEST_METHOD") | |||
| context.http_headers = collect_http_headers(environ) | |||
| context.qs_params = parse_query_string(environ.get("QUERY_STRING")) | |||
There was a problem hiding this comment.
ok, it looks good to me in this way
A POST request can have a query string. In that case context.request
will hold the data from the POST request body, and thus there is no
place to hold the query params.
With this changeset, a new property is introduced to hold the query
string, parsed as query params. The query params is a list of tuples.
Each tuple holds two elements, the query param name and the query param
value. Params with no value are dropped.
?param_w_value=123¶m_w_no_value
Signed-off-by: Ivan Kanakarakis <[email protected]>
Signed-off-by: Ivan Kanakarakis <[email protected]>
Signed-off-by: Ivan Kanakarakis <[email protected]>
c00kiemon5ter
force-pushed
the
refactor-context-query-params
branch
from
7eaff80 to
b50f70b
Compare
c00kiemon5ter
changed the title
c00kiemon5ter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A POST request can have a query string. In that case context.request
will hold the data from the POST request body, and thus there is no
place to hold the query params.
With this changeset, a new property is introduced to hold the query
string, parsed as query params. The query params is a list of tuples.
Each tuple holds two elements, the query param name and the query param
value. Params with no value are dropped.
All Submissions: