Skip to content

feat: improve error messages #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel merged 1 commit into from
Oct 8, 2025
Merged

feat: improve error messages #1259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions src/pdl/pdl_interpreter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,14 @@ def process_block_body_with_replay(
block.pdl__id = block_id
if isinstance(block, LeafBlock) and not isinstance(block, CallBlock):
assert isinstance(block_id, str)
try:
if block_id not in state.replay:
result, background, scope, trace = process_block_body(
state, scope, block, loc
)
state.replay[block_id] = result
else:
result = state.replay[block_id]
background: LazyMessages = SingletonContext(
background = SingletonContext(
PdlDict({"role": state.role, "content": result})
)
if state.yield_result:
Expand All @@ -690,11 +695,6 @@ def process_block_body_with_replay(
assert block.pdl__id is not None
raw_result = state.replay[block.pdl__id + ".modelResponse"]
scope = scope | {block.modelResponse: raw_result}
except KeyError:
result, background, scope, trace = process_block_body(
state, scope, block, loc
)
state.replay[block_id] = result
else:
result, background, scope, trace = process_block_body(state, scope, block, loc)
return result, background, scope, trace
Expand Down Expand Up @@ -2099,6 +2099,14 @@ def process_call_code(
}
)
)
except PDLRuntimeExpressionError as exc:
raise PDLRuntimeError(
f"Python Code error: {exc.message}",
loc=loc,
trace=block.model_copy(
update={"code": code_s, "pdl__defsite": block.pdl__id}
),
) from exc
except Exception as exc:
raise PDLRuntimeError(
f"Python Code error: {traceback.format_exc()}",
Expand Down Expand Up @@ -2198,9 +2206,14 @@ def process_call_code(
def call_python(code: str, scope: ScopeType, state: InterpreterState) -> PdlLazy[Any]:
my_namespace = types.SimpleNamespace(PDL_SESSION=__PDL_SESSION, **scope)
sys.path.append(str(state.cwd))
exec(code, my_namespace.__dict__) # nosec B102
# [B102:exec_used] Use of exec detected.
# This is the code that the user asked to execute. It can be executed in a docker container with the option `--sandbox`
try:
c = compile(code, "<code-block>", "exec")
exec(c, my_namespace.__dict__) # nosec B102
# [B102:exec_used] Use of exec detected.
# This is the code that the user asked to execute. It can be executed in a docker container with the option `--sandbox`
except Exception as exc:
message = traceback.format_exc()
raise PDLRuntimeExpressionError(message) from exc
result = my_namespace.result
sys.path.pop()
return PdlConst(result)
Expand Down