Read current service expiry from service object for service extension… #32
+44
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vikasbolla
commented
Jan 27, 2026
vikasbolla
commented
- Recently we have added the service limit extension check as part of this PR- Limit service expiry extension request to 5 Days #27. Since the current expiry date and time was read from db and for the new service the db entry does not exist, this check is currently getting by passed. So instead of reading from DB, it should be read from service object.
| request: getResource("get-request-by-id-before-expiry", nil).(*models.Request), | ||
| }, | ||
| { | ||
| name: "service expiry extesnion beyond maximum allowed", |
Collaborator
There was a problem hiding this comment.
Suggested change
| name: "service expiry extesnion beyond maximum allowed", | |
| name: "service expiry extension beyond maximum allowed", |
… limit check Signed-off-by: Vikas <[email protected]>
vikasbolla
force-pushed
the
fix_extension
branch
from
2f5dc57 to
4e1eb27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.