Use values.data.get() in GatewayUpdate to Fix Pydantic Error Issue#630 #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RAKHI DUTTA <[email protected]>
rakdutta
changed the title
rakdutta
changed the title
crivetimihai
approved these changes
Jul 29, 2025
Member
crivetimihai
left a comment
crivetimihai
left a comment
There was a problem hiding this comment.
This addresses a backend validation bug that was causing silent failures when updating a Gateway through the UI.
The original issue stemmed from attempts to access data in a Pydantic v2 ValidationInfo object using .get(), which resulted in an AttributeError and prevented the frontend from displaying meaningful validation errors.
Your fix correctly updates all relevant instances to use values.data.get(...), aligning with the proper way to access submitted values in Pydantic v2 validators. This resolves the backend exception and ensures that validation failures will now propagate as intended, allowing the frontend to inform users of specific issues during Gateway updates.
Testing
-
make doctest testpassed
2 tasks
vk-playground
pushed a commit
to vk-playground/mcp-context-forge
that referenced
this pull request
Sep 14, 2025
Signed-off-by: RAKHI DUTTA <[email protected]> Co-authored-by: RAKHI DUTTA <[email protected]>
vk-playground
pushed a commit
to vk-playground/mcp-context-forge
that referenced
this pull request
Sep 14, 2025
Signed-off-by: RAKHI DUTTA <[email protected]> Co-authored-by: RAKHI DUTTA <[email protected]>
vk-playground
pushed a commit
to vk-playground/mcp-context-forge
that referenced
this pull request
Sep 16, 2025
Signed-off-by: RAKHI DUTTA <[email protected]> Co-authored-by: RAKHI DUTTA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
📌 Summary
[Bug]: Gateway update fails silently in UI, backend throws ValidationInfo error
Replaced value.get() with value.data.get() in the GatewayUpdate class in schema.py to correctly access values from the ValidationInfo object.