Skip to content

[IMA/GMA] Fix race condition in adapters where we reported initialized too early #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2024
Merged

[IMA/GMA] Fix race condition in adapters where we reported initialized too early #87

merged 1 commit into from
Jun 10, 2024

Conversation

@IanDBird
Copy link
Collaborator

@IanDBird IanDBird commented Jun 10, 2024

This PR fixes a theoretical race condition that could occur if:

  • The adapter is initialized before the UID2Manager has been previously set up
    • This shouldn't happen if the integrator has followed the integration guide to ensure this is part of the Application creation. However, since we can't enforce this, we should try to be as safe as possible
  • The signals are requested immediately after the adapter is initialized.

Since the UID2Manager is potentially restoring the identity from disk, it's possible that for a few ms, we will report a null token before it's loaded.

@IanDBird IanDBird force-pushed the ian/adapter-race-condition branch from d23386a to e67b16b Compare June 10, 2024 10:32
@IanDBird IanDBird merged commit bccd391 into main Jun 10, 2024
@IanDBird IanDBird deleted the ian/adapter-race-condition branch June 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrmans0n mrmans0n mrmans0n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IanDBird @mrmans0n