fix: BROS-641: Select annotation from username in Compare #8898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a regression: username/userpic still have pointer cursor in Compare table in View All, but click on them does nothing. The reason is the change in `selectAnnotation()` method — now it doesn't close View All by default, we need to pass an option `exitViewAll: true` to it.
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
yyassi-heartex
approved these changes
Nov 26, 2025
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #8898 +/- ##
===========================================
- Coverage 65.09% 57.74% -7.36%
===========================================
Files 828 561 -267
Lines 64773 40877 -23896
Branches 11041 11041
===========================================
- Hits 42164 23603 -18561
+ Misses 22605 17270 -5335
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
They were not actually selecting new annotation
Collaborator
Author
|
/git merge
|
nick-skriabin
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a regression: username/userpic still have pointer cursor in Compare table in View All, but click on them does nothing.
The reason is the change in
selectAnnotation()method — now it doesn't close View All by default, we need to pass an optionexitViewAll: trueto it.Also fixed "Create New Annotation" and "Duplicate Annotation" actions.