Skip to content

Refactor buffer concatenation #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Refactor buffer concatenation #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,12 @@ const METHOD_OFFSET = '/api/'.length;

const clients = new Map();

const receiveArgs = async req => new Promise(resolve => {
const body = [];
const receiveBody = async req => new Promise(resolve => {
const buffers = [];
req.on('data', chunk => {
body.push(chunk);
}).on('end', async () => {
const data = body.join('');
const args = JSON.parse(data);
resolve(args);
buffers.push(chunk);
}).on('end', () => {
resolve(Buffer.concat(buffers).toString());
});
});

Expand Down Expand Up @@ -58,8 +56,9 @@ const listener = (req, res) => {
client.error(403, new Error(`Forbidden: ${url}`));
return;
}
receiveArgs(req).then(args => {
receiveBody(req).then(body => {
const method = url.substring(METHOD_OFFSET);
const args = JSON.parse(body);
client.rpc(method, args);
});
} else {
Expand Down