Skip to content

Conversation

@wing328
Copy link
Contributor

@wing328 wing328 commented Jun 18, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ilovezfs
Copy link
Contributor

Did you have a chance to work on the test?

@wing328
Copy link
Contributor Author

wing328 commented Jun 18, 2018

@ilovezfs just fixed it and the result looks good:

➜  homebrew-core git:(openapi-generator-3.0.2) ✗ brew test -v --build-from-source ./Formula/openapi-generator.rb
Testing openapi-generator
/usr/bin/sandbox-exec -f /tmp/homebrew20180618-34749-13puwdc.sb /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby -W0 -I /usr/local/Homebrew/Library/Homebrew -- /usr/local/Homebrew/Library/Homebrew/test.rb /Users/williamcheng/Code/homebrew-core/Formula/openapi-generator.rb -v --build-from-source
==> /usr/local/Cellar/openapi-generator/3.0.2/bin/openapi-generator generate -i minimal.yaml -g openapi
Picked up _JAVA_OPTIONS:  -Duser.home=/Users/williamcheng/Library/Caches/Homebrew/java_cache
[main] INFO  o.o.c.ignore.CodegenIgnoreProcessor - No .openapi-generator-ignore file found.
[main] INFO  o.o.codegen.DefaultGenerator - writing file /private/tmp/openapi-generator-test-20180618-34750-t8mro3/./README.md
[main] INFO  o.o.codegen.AbstractGenerator - writing file /private/tmp/openapi-generator-test-20180618-34750-t8mro3/./.openapi-generator-ignore
[main] INFO  o.o.codegen.AbstractGenerator - writing file /private/tmp/openapi-generator-test-20180618-34750-t8mro3/./.openapi-generator/VERSION
[main] INFO  o.o.c.languages.OpenAPIGenerator - wrote file to /private/tmp/openapi-generator-test-20180618-34750-t8mro3/./openapi.json

@ilovezfs ilovezfs merged commit 7b1c45b into Homebrew:master Jun 18, 2018
@ilovezfs
Copy link
Contributor

perfect! Thanks @wing328

@wing328 wing328 deleted the openapi-generator-3.0.2 branch June 19, 2018 17:59
@wing328
Copy link
Contributor Author

wing328 commented Jun 19, 2018

@ilovezfs thanks for the quick merge 👍

@lock lock bot added the outdated PR was locked due to age label Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants