kubescape 2.0.164 #106523
kubescape 2.0.164 #106523
Conversation
| resource "libgit2" do | ||
| url "https://github.com/libgit2/libgit2/archive/refs/tags/v1.3.0.tar.gz" | ||
| sha256 "192eeff84596ff09efb6b01835a066f2df7cd7985e0991c79595688e6b36444e" | ||
| end |
There was a problem hiding this comment.
The problem with the libgit2 formula is that I need specific version 1.3.0, which would work with git2go v33 (https://github.com/libgit2/git2go#which-go-version-to-use)
Can you advise what would be the best approach in this case?
There was a problem hiding this comment.
Updating git2go, and by extension kubescape to work with a modern version of it's dependencies.
There was a problem hiding this comment.
@SMillerDev We are using the latest version of that go module - https://pkg.go.dev/github.com/libgit2/git2go/v33
There's an open issue for that upgrade for a few months (
libgit2/git2go#899)
There was a problem hiding this comment.
Looks like they were waiting for libgit2/libgit2#6278 to land. It has now, and is in a stable release.
| ldflags = %W[ | ||
| -s -w | ||
| -X github.com/armosec/kubescape/v2/core/cautils.BuildNumber=v#{version} | ||
| ] | ||
|
|
||
| system "go", "build", *std_go_args(ldflags: ldflags) | ||
| system "make", "libgit2" | ||
| system "go", "build", *std_go_args(ldflags: ldflags), "-tags", "static" |
There was a problem hiding this comment.
This should not be statically linking
There was a problem hiding this comment.
@SMillerDev I do see other formulas in the homebrew-core repository which use static linking
There was a problem hiding this comment.
Can you point them out, because they should really be fixed not to do that.
There was a problem hiding this comment.
I assume those would be sslscan, tanka, geos, proj, jsonnet-bundler
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?version bump to 2.0.164
fixed build process