introduce respectWhitespace parse option #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Collaborator
Author
|
@HenrikJoreteg any reaction from your side would help a lot here: |
Owner
HenrikJoreteg
left a comment
HenrikJoreteg
left a comment
There was a problem hiding this comment.
Thanks for this @adrai. I just have one comment, really.
Owner
|
I'm tempted to just do a major version bump and change the behavior to always preserve it, what do you think? |
Collaborator
Author
|
I was thinking the same when creating the PR, but did not want to break the existing behaviour. |
Collaborator
Author
|
So let's close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should help to fix: i18next/react-i18next#1283
originally from here: https://github.com/rayd/html-parse-stringify2/blob/master/lib/parse.js#L14