Show progress in git based installs #641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
reviewed
Aug 17, 2024
| p.stdin.close(); | ||
|
|
||
| // In certain cases of git clones, it will hang on reading from stderr | ||
| // if we don't read from it. So we will always try to read from it. |
Member
There was a problem hiding this comment.
The reason this was solved with threads on windows is that the same thing could happen with p.stdout and p.stderr at the same time, in which case the only solution is to read from both simultaneously (with separate threads).
However, the threads caused issues on Linux so I made it windows only in: b8c24a7. I suspect the same issue is also behind these crashes: #591
Member
There was a problem hiding this comment.
Neko has been patched so I have reapplied that original fix for all platforms. That should handle the stderr/stdout issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #635
Adds a
--progressflag to thegit clonecommand, which will spit out the information / progress of the cloning operation.This implementation will run a
whileloop that reads the available bytes as they come in and spits them out to theSys.stdout, and will continue until it gets anEOFerror (git clone operation finished), which then it will read all of the bytes + exit code and return it as usual.