-
-
Notifications
You must be signed in to change notification settings - Fork 310
Add a gallery page to visualize all available flags #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I love this. As you can see I mentioned this over on #4 (now below) where I was mainly rambling about my own take at a gallery page. I like that it's built with Jekyll, and I like that all that's needed is a simple ctrl/cmd+f to find what you're looking for. I think we should link to the gallery from the README.md as well. |
|
Comment moved from #4:
|
|
Glad to hear you've been working on this! It shows that I'm aiming in the right direction :)
That's pretty ingenious! I do wonder, though, how useful that would be for country flags (as opposed to generic icons). I mean, when one needs to use the flag of a country, there usually isn't much of a choice about the colors you can pick. The approach does sound amazingly helpful for a more generic set of svg icons, though! I hope you're able to set it up in such a project :)
Isn't that what I did already? Maybe I should make the link more prominent?
Yeah, often the simpler solutions tend to be more resilient and maintainable in the long run. 🙂 I particularly like that it degrades well to markdown rendering right on GitHub, without sacrificing the nicer layout in the website (I actually went through a few iterations until I found such a polyglot implementation for the gallery page). I don't think it's an issue that the page isn't generated automatically, since this collection is already pretty comprehensive, so it won't be much trouble to update the gallery page manually when new flags are added. IMO it's worth the extended compatibility and simplicity. |
|
One thing I wanted to ask is whether you'd want to split the list into national vs. subnational flags, languages, fictional entities, etc. I can see from the screenshot in your comment in #4 that you have something along these lines in mind already. I just started with a flat list because it was easier. That said, it could make more sense to add the flat gallery as a start, matching the current flat structure of the |
|
You're right, it was more of a proof of concept type thing. And there's a lot of flags. I wasn't just thinking of country flags. The repo is mischievously titled circle-flags, ultimately allowing for expansion to include virtually any type of flag, so long as it follows the correct design scheme and has the right color palette. This would include flags for states, provinces, territories, cities, towns, historical, fictional, and so on. So that's a lot of flags ultimately. Another idea was being able to filter flags by vexillological elements, or how many stripes they have and in what directions. A geeky homage to graphic/web design and vexillology. But with the added benefit of it being functional and practical.
Yeah sorry I missed it in the commits; I don't use GitHub that often. |
|
But I love this PR, @waldyrious. Thank you again for your help revitalising the repo. 😄 |
Interesting... do you have these guidelines written down somewhere? It would be nice for potential contributors.
That sounds great! I know that some similar efforts have been put in place in FOTW (e.g. But all of these are maintained manually; the automated approach for the colors that you describe above would be a much more scalable approach; and for shapes, we could leverage the proposal of keeping unoptimized versions of the files in the repo, ensuring that they use SVG shapes like
I was actually quite pleased that you engaged with my contributions so promptly, since the repo had been dormant for a while — at times I've had PRs wait years until they got a response, so this was a welcome change of pace :) |
As of right now I do not, but you are right.
Indeed, FOTW is a great resource and my endeavours are largely inspired by their flag identification tool. And I knew Wikimedia was an invaluable resource but I didn't realise just how specific some of their categories for flags got.
The overlay
type=flag
path=uk.flag
x=0
y=0
width=10
height=5Flags from Wikimedia for illustrative purposes: And the .flag files refer to custom shape presets such as stars.
Ah, no problem! I was surprised but glad to see somebody taking an interest in this repo. |
|
Wow... that flag search feature is really something! I can see how that would inspire you to make an interactive one :) And thanks for introducing me to the Anyway, I wonder if it would be possible to transform (essentially, transpile) .flag files directly to SVG. I noticed that FlagMaker can export to SVG, but the code to do so is spread across the app's codebase, and quite entangled with it — it starts in FileHandler.ExportFlagToSvg(), which then calls the abstract methods Division.ExportSvg() (with concrete implementations in DivisionPales, DivisionFesses, etc.) and Overlay.ExportSvg() (with concrete implementations in OverlayBox, OverlayEllipse, etc.). It would be nice to have a stand-alone converter from Of course, the easier approach would be to simply store a map of this repo's svg filenames to FlagMaker's .flag filenames; that would only require a parser for the |
Nice! I am only familiar with FlagMaker through the /r/vexillology subreddit. I believe it's been greatly popularised by that sub. It looks like we can find more info by trawling that sub. FlagMaker is made by Andrew Arnold (u/5thEye on Reddit). Useful links:
Edit: I've never used Wikidata before so I didn't see at first that you already included the version update Reddit threads. It also looks like someone also posts most (if not all - haven't done an exhaustive search) FlagMaker version updates to /r/vexillology, which many contain information additional to FlagMaker's version history:
In my searching I also found this website with many links to vexillological resources including flag identifiers and designers. Should I move this comment all about FlagMaker into its own issue? |
Thank you for your encouragement. Yet I still agree with your original objection that perhaps it is not appropriate if this repo is to be a simple SVG flag library. Though there are elements to the whole circle-flags "webapp" idea that could be very useful to maintaining this flag library, and indeed, with a scaleable/extensible enough approach, the webapp could ultimately be used for maintaining any kind of SVG icon library. Perhaps I too am daydreaming. I also have no idea whether such an application already exists. |
Yeah, I had figured as much — I also created a Wikidata entry for him :) (and a Wikimedia Commons category for the program, and Wikidata items for FlagMaker2 and FlagMaker Jr and the .flag file format! 😄)
Those were actually all posted by the author himself! Except of course the FlagMaker Jr. Plus announcement — thanks for pointing me to it :) And to the other resources — it's really a deep rabbit hole to go into, there's so much stuff around! :)
Not sure I see the benefit — what would be the end goal of such an issue? Maybe a wiki page would work better if what you're aiming for is a reference information about flag design. |

I've tested this using my fork, and it seems to work well.
Here's how the page looks when rendered by Jekyll:
https://waldyrious.github.io/circle-flags/all-flags.html
and here's how the markdown file is shown on GitHub:
https://github.com/waldyrious/circle-flags/blob/gallery-page/all-flags.md
Happy to make any adjustments you deem necessary.