fix: prevent infinite height growth in time picker #6104
Merged
+58
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6104 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 30 30
Lines 3647 3649 +2
Branches 1574 1558 -16
=======================================
+ Hits 3619 3621 +2
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The ResizeObserver watching the month container could trigger an infinite loop: updating the time list height caused a re-render, which triggered another resize event, and so on. This fix only updates the height state when the calculated height actually differs from the current state, breaking the infinite loop. Added a test to verify the resize callback can be called multiple times without causing height changes. Fixes #5551 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
martijnrusschen
force-pushed
the
fix/issue-5551-infinite-time-picker-height
branch
from
f2b2df8 to
ad73e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ResizeObserver watching the month container could trigger an infinite loop: updating the time list height caused a re-render, which triggered another resize event, and so on.
This fix only updates the height state when the calculated height actually differs from the current state, breaking the infinite loop.
Fixes #5551