Keyboard menu/widget navigation #628

0HyperCube · 2022-05-07T17:42:36Z

Closes #575

cloudflare-workers-and-pages · 2022-05-10T16:56:23Z

Deploying with Cloudflare Pages

Latest commit:	`8752110`
Status:	✅ Deploy successful!
Preview URL:	https://94c11dc2.graphite-master.pages.dev

View logs

Keavon · 2022-05-19T16:00:56Z

I'm currently looking at merging #649 first since it'll be easier to deal with conflicts in that order. Still working on investigating a bug in that branch though.

Keavon

Looking good! My earlier concerns are now resolved.

frontend/src/App.vue

frontend/src/components/widgets/WidgetSection.vue

frontend/src/App.vue

frontend/src/components/widgets/floating-menus/MenuList.vue

frontend/src/components/widgets/inputs/FontInput.vue

frontend/src/components/widgets/separators/Separator.vue

frontend/src/io-managers/input.ts

frontend/src/components/widgets/inputs/MenuBarInput.vue

Keavon · 2022-05-23T07:04:46Z

Only one small request: when using the arrow keys to navigate a menu, reaching the end should cap rather than looping back to the start.

frontend/src/components/widgets/floating-menus/DialogModal.vue

0HyperCube · 2022-05-23T17:02:26Z

Only one small request: when using the arrow keys to navigate a menu, reaching the end should cap rather than looping back to the start.

The standard behavior in gtk appears to be to have looping in the menubar but not in the dropdowns. I will add this.

frontend/src/components/floating-menus/DialogModal.vue

editor/src/document/document_message_handler.rs

Keavon

Good to merge (after the last comment)! Sorry for the repeated nitpicks.

Keavon · 2022-05-24T23:48:32Z

An issue with the starting active color:

https://files.keavon.com/-/FirstLuminousPrayingmantid/capture_4_.mp4

Keavon · 2022-05-25T18:43:41Z

Here's a list of a few more issues I ran into while QA testing. Feel free to fix now or merge now and fix later.

I'm noticing one small UX inconsistency: Space or Enter work for Menu Bar and Dropdown inputs, but only Enter works for buttons.
Opening Menu Bar groups with Space/Enter doesn't close other open ones so multiple stack up at the same time. And when you've tabbed away from the open menu bar, Escape doesn't exit it either (but that should be impossible to cause once the previous sentence is fixed).
Doesn't have to be in this PR, but we should make Escape close the open popover. This works on Dialogs and MenuLists but not Popovers.
If you hold down the up/down keys to switch blend modes, it takes a little time to apply because of the backend being slow to update the frontend. But if you reach the end and keep holding the down key, it still (I assume) stacks up change requests and freezes the backend for a long time. We should ideally cap that on the frontend so the keyrepeat of holding down the arrow keys shouldn't freeze the editor longer than the time it would take to freeze for every item in the list before reaching the end, rather than stacking up an indefinite length of freezes by going past the end.

* Keyboard menu navigation * Fix dropdown keyboard navigation * Fix merge error * Some code review * Interactive dropdowns * Query by data attr not class name * Add locking behaviour * Change query selector style * Change query selector style (again) * Code review feedback * Fix highlighted entry regression * Styling and disabling checkbox tabindex in MenuLists * Don't redirect space off canvas to backend * Do not emit update if value same * Escape closes all floating menus * Close dropdowns on blur Co-authored-by: Keavon Chambers <[email protected]>

Keyboard menu navigation

2566c1f

0HyperCube mentioned this pull request May 7, 2022

Editor GUI keyboard navigation #575

Closed

6 tasks

Keavon linked an issue May 8, 2022 that may be closed by this pull request

Editor GUI keyboard navigation #575

Closed

6 tasks

Keavon marked this pull request as draft May 8, 2022 22:02

Keavon force-pushed the master branch from c225581 to ae43ae8 Compare May 10, 2022 10:06

Keavon force-pushed the widget-keyboard-nav branch from 7580133 to 2566c1f Compare May 10, 2022 16:49

Keavon force-pushed the master branch 2 times, most recently from c0faee2 to 5a3db9b Compare May 12, 2022 21:22

0HyperCube and others added 2 commits May 16, 2022 19:54

Fix dropdown keyboard navigation

5fa20a9

Merge branch 'master' into widget-keyboard-nav

f14591b

0HyperCube marked this pull request as ready for review May 16, 2022 18:55

0HyperCube requested a review from Keavon May 16, 2022 18:55

0HyperCube and others added 2 commits May 19, 2022 16:56

Merge branch 'master' into widget-keyboard-nav

2e2bc54

Fix merge error

2cca3e5

Merge branch 'master' into widget-keyboard-nav

4621410

Keavon requested changes May 22, 2022

View reviewed changes

Some code review

8e0e144

Keavon reviewed May 22, 2022

View reviewed changes

frontend/src/components/widgets/inputs/MenuBarInput.vue Show resolved Hide resolved

Interactive dropdowns

1106407

Keavon reviewed May 23, 2022

View reviewed changes

frontend/src/components/widgets/floating-menus/DialogModal.vue Outdated Show resolved Hide resolved

Keavon approved these changes May 23, 2022

View reviewed changes

0HyperCube added 2 commits May 23, 2022 17:13

Query by data attr not class name

9970454

Add locking behaviour

641740a

Merge branch 'master' into widget-keyboard-nav

f324b6f

Keavon reviewed May 24, 2022

View reviewed changes

frontend/src/components/floating-menus/DialogModal.vue Outdated Show resolved Hide resolved

Change query selector style

5e8a477

Keavon reviewed May 24, 2022

View reviewed changes

frontend/src/components/floating-menus/DialogModal.vue Outdated Show resolved Hide resolved

Change query selector style (again)

8795117

Keavon reviewed May 24, 2022

View reviewed changes

editor/src/document/document_message_handler.rs Outdated Show resolved Hide resolved

Keavon approved these changes May 24, 2022

View reviewed changes

Code review feedback

85d2cbd

0HyperCube and others added 3 commits May 25, 2022 17:26

Fix highlighted entry regression

f8d695e

Merge branch 'master' into widget-keyboard-nav

4fa0414

Styling and disabling checkbox tabindex in MenuLists

a3a8b72

0HyperCube added 4 commits May 25, 2022 21:17

Don't redirect space off canvas to backend

7e79b16

Do not emit update if value same

0a9f197

Escape closes all floating menus

fb3a1ce

Close dropdowns on blur

8752110

Keavon changed the title ~~Keyboard menu navigation~~ Keyboard menu/widget navigation May 25, 2022

Keavon merged commit 2e5ccfe into master May 25, 2022

Keavon deleted the widget-keyboard-nav branch May 25, 2022 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Keyboard menu/widget navigation #628

Keyboard menu/widget navigation #628

Uh oh!

0HyperCube commented May 7, 2022 •

edited by Keavon

Loading

Uh oh!

cloudflare-workers-and-pages bot commented May 10, 2022 •

edited

Loading

Uh oh!

Keavon commented May 19, 2022

Uh oh!

Keavon left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Keavon commented May 23, 2022

Uh oh!

Uh oh!

0HyperCube commented May 23, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Keavon left a comment

Uh oh!

Keavon commented May 24, 2022 •

edited

Loading

Uh oh!

Keavon commented May 25, 2022 •

edited by 0HyperCube

Loading

Uh oh!

Uh oh!

Uh oh!

Keyboard menu/widget navigation #628

Keyboard menu/widget navigation #628

Uh oh!

Conversation

0HyperCube commented May 7, 2022 • edited by Keavon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

Keavon commented May 19, 2022

Uh oh!

Keavon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Keavon commented May 23, 2022

Uh oh!

Uh oh!

0HyperCube commented May 23, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Keavon left a comment

Choose a reason for hiding this comment

Uh oh!

Keavon commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Keavon commented May 25, 2022 • edited by 0HyperCube Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

0HyperCube commented May 7, 2022 •

edited by Keavon

Loading

cloudflare-workers-and-pages bot commented May 10, 2022 •

edited

Loading

Keavon left a comment •

edited

Loading

Keavon commented May 24, 2022 •

edited

Loading

Keavon commented May 25, 2022 •

edited by 0HyperCube

Loading