Change Table<Color> node inputs to Color where only one value is used so GPU nodes work
#3096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
force-pushed
the
shaders_table_color_to_color
branch
2 times, most recently
from
ace6707 to
9735bfe
Compare
Firestar99
force-pushed
the
f32_support
branch
from
8545df8 to
3a49a47
Compare
Firestar99
force-pushed
the
shaders_table_color_to_color
branch
from
9735bfe to
ad83e7f
Compare
0HyperCube
force-pushed
the
shaders_table_color_to_color
branch
from
ad83e7f to
9735bfe
Compare
Firestar99
force-pushed
the
f32_support
branch
from
3a49a47 to
6917695
Compare
Firestar99
force-pushed
the
shaders_table_color_to_color
branch
from
66f9e4c to
6c9ee70
Compare
Keavon
changed the title
Table<Color> params to Color where only one value is usedTable<Color> node inputs to Color where only one value is used so GPU nodes work
Firestar99
force-pushed
the
shaders_table_color_to_color
branch
from
6c9ee70 to
b68c3dc
Compare
TrueDoctor
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted commit from #3090
I'm changing them to
Colorfor now,will submit a followup PR after all the shader stuff is merged to switch them toOption<Color>, as discussed with @Keavon in #3090 (comment)CHANGE: I'm running into some issues with rust-gpu when using
Option, so it'll have to remain asColoruntil rust-gpu improves to handle that better. Pushed my work toshaders-option-colorbranch.Color UI is also completely broken. @0HyperCube feel free to take this one (and the f32 one) over. Can be rebased on master on it's own, if you want to.you fixed it ❤️