Implement basic desktop app with chromium embeded framework #2874
+2,720
−2,932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timon-schelling
force-pushed
the
desktop-app
branch
15 times, most recently
from
0806b05 to
809a009
Compare
timon-schelling
force-pushed
the
desktop-app
branch
from
809a009 to
5e4d5d1
Compare
timon-schelling
force-pushed
the
desktop-app
branch
2 times, most recently
from
5e4d5d1 to
c5d0e41
Compare
TrueDoctor
approved these changes
Jul 23, 2025
Firestar99
reviewed
Jul 24, 2025
| fn main() { | ||
| let frontend_dir = format!("{}/../frontend/dist", env!("CARGO_MANIFEST_DIR")); | ||
| metadata(&frontend_dir).expect("Failed to find frontend directory. Please build the frontend first."); | ||
| metadata(format!("{}/index.html", &frontend_dir)).expect("Failed to find index.html in frontend directory."); |
There was a problem hiding this comment.
Could you explain to me why this build.rs exists? Just to verify the frontend is build? Two scenarios:
- You are embedding the frontend/dist folder in the executable: Then the embedding process should fail during build, not the build script during check.
- You are referencing this folder from code and it will be distributed alongside the executable: Then wouldn't a simple
#[test]protect against failure? - Also consider just building the frontend in the build script?
Background: Every cargo check, cargo test or cargo build now fails if you didn't explicitly build the frontend first.
There was a problem hiding this comment.
It is the first case, and for me it was just a way to provide better feedback to devs. But I didn't think about your Issue. Feel free to open a pr. Or I will take a look maybe tomorrow.
There was a problem hiding this comment.
For now I can just comment out the build.rs, rather you have a look cause you also know how the embedding works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
Known issues:
[ERROR:components/viz/service/main/viz_main_impl.cc:184] Exiting GPU process due to errors during initialization[ERROR:content/browser/gpu/gpu_process_host.cc:957] GPU process exited unexpectedly: exit_code=133[FATAL:content/browser/gpu/gpu_data_manager_impl_private.cc:415] GPU process isn't usable. Goodbye.[ERROR:google_apis/gcm/engine/registration_request.cc:291] Registration response error message: DEPRECATED_ENDPOINTSubprocess of type zygote failedOther possible improvements: