[FEATURE REQUEST] ignoreRelocation

[iiAhmedYT]

This is a bit of a painful request and might not be of much use cases but here we go.

First of all thank you for taking the time and forking "shadow", I did panic when I first saw that issue on the main repository.

So when you relocate X package its relocated everywhere. No exceptions, no messing around, however I wish there was an option for lets say Util class to keep the old packages as it was

So If we relocate
me.iiahmed.x ==> me.iiahmed.y
It should be me.iiahmed.y everywhere as usual, except for the class we specified (Util) it should be me.iiahmed.x to stay as it is.

Thank you in advance.

[samotoo]

I believe this is already possible using this plugin by:

relocate("me.iiahmed.x", "me.iiahmed.y") {
  exclude("me.iiahmed.x.util")
}

I have used this syntax to relocate jackson except for its annotations.

But I would like to suggest another feature. By setting enableRelocation to true, the plugin automatically relocates all dependencies. This is pretty handy if most of the depdencies are meant to be relocated. But I cannot find a way to exclude certain packages to make them stay in original locations.

So now I have to explicity relocate dependencies one by one, which is a bit cumbersome. It would be great to provide an option to exclude packages from relocation globally.

And thanks very much for forking the project. This is really an essential part of the gradle eco-system.

[iiAhmedYT]

I believe this is already possible using this plugin by:

relocate("me.iiahmed.x", "me.iiahmed.y") {
  exclude("me.iiahmed.x.util")
}

I have used this syntax to relocate jackson except for its annotations.

But I would like to suggest another feature. By setting enableRelocation to true, the plugin automatically relocates all dependencies. This is pretty handy if most of the depdencies are meant to be relocated. But I cannot find a way to exclude certain packages to make them stay in original locations.

So now I have to explicity relocate dependencies one by one, which is a bit cumbersome. It would be great to provide an option to exclude packages from relocation globally.

And thanks very much for forking the project. This is really an essential part of the gradle eco-system.

Just tried that but i dont think it works?

[iiAhmedYT]

Or actually this is a misunderstanding

excluding "me.iiahmed.x.Util" means it doesn't relocate that class

I still want it relocated.. JUST not in "me.iiahmed.fish.RVF" i want this class to use original imports (me.iiahmed.x.Util instead of me.iiahmed.y.Util)

[samotoo]

Or actually this is a misunderstanding

excluding "me.iiahmed.x.Util" means it doesn't relocate that class

I still want it relocated.. JUST not in "me.iiahmed.fish.RVF" i want this class to use original imports (me.iiahmed.x.Util instead of me.iiahmed.y.Util)

I think it is not a misunderstanding. The exclude api will make the class stay in its original package. Maybe you used the wrong api. There are two exclude apis:

• com.github.jengelman.gradle.plugins.shadow.relocation.SimpleRelocator#exclude(String pattern)

This will make the intended classes in original packages, but still included in the shadow jar.

• org.gradle.api.file.CopySpec#exclude(java.lang.String...)

This will exclude the class from the shadow jar.

Make sure you are calling the first one.

[iiAhmedYT]

I assure you i used the first one and you probably still don't understand:D

[amaranth]

What would be the point of having me.iiahmed.x.Util reference all of its imports as me.iiahmed.x if they don't exist anymore? Do you want it to copy those imports so they exist under me.iiahmed.x and me.iiahmed.y? If so, should it do that recursively?