fix: minimize custom tests used #9538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
Contributor
Author
|
The existing test suite creates deletes several tests, but the deleted tests still count against quota for up to 14 days. Now that the quota has been hit, it seems that there will never be enough unused quota for the test suite to create all the roles it wants to before it uses it up again. We should merge this change so the test suite uses only one role, and once the old deleted roles start to age out, it should be able to run to completion. |
nicain
approved these changes
Apr 10, 2023
rsamborski
approved these changes
Apr 11, 2023
m-strzelczyk
approved these changes
Apr 11, 2023
Contributor
|
I agree to admin-merge this, but first fix the lint problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9532 #9525 #9526
There is a hard quota of 300 custom roles per project, and deleted custom roles still count against that quota for up to 14 days, so this test now creates and deletes only one custom role when run.