Skip to content

fix: type linting issue #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glasnt merged 5 commits into from
Apr 19, 2022
Merged

fix: type linting issue #7789

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd1522c
Fix type linting issuse (borrows from 7788)
glasnt Apr 12, 2022
2f4bce7
Correct import
glasnt Apr 12, 2022
56c1977
Merge branch 'main' into topic/deployment-types
glasnt Apr 14, 2022
9a2a8eb
Merge branch 'main' into topic/deployment-types
Apr 15, 2022
4dd29c9
Merge branch 'main' into topic/deployment-types
glasnt Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions run/deployment-previews/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,16 @@
# limitations under the License.

import os
from typing import Any, List, NoReturn
from typing import List, NoReturn, TypeVar

from click.testing import CliRunner
from mock import MagicMock, patch
import pytest

from check_status import cli

a = TypeVar("a")

MOCK_SERVICE_NAME = "myservice"
MOCK_GH_TOKEN = "aaaaa"
MOCK_REPO_NAME = "foocorp/bar"
Expand Down Expand Up @@ -70,7 +72,7 @@ def service_data(name: str, tags: List[str]) -> dict:


@patch("check_status.discovery")
def test_set_wrongtag(discovery_mock: Any) -> NoReturn:
def test_set_wrongtag(discovery_mock: a) -> NoReturn:
service_mock = MagicMock()
service_mock.projects = MagicMock(return_value=service_mock)
service_mock.locations = MagicMock(return_value=service_mock)
Expand Down Expand Up @@ -110,7 +112,7 @@ def test_set_wrongtag(discovery_mock: Any) -> NoReturn:

@patch("check_status.discovery")
@patch("check_status.github")
def test_set_check_calls(github_mock: Any, discovery_mock: Any) -> NoReturn:
def test_set_check_calls(github_mock: a, discovery_mock: a) -> NoReturn:
service_mock = MagicMock()
service_mock.projects = MagicMock(return_value=service_mock)
service_mock.locations = MagicMock(return_value=service_mock)
Expand Down