Skip to content

chore: increase wait time for custom metric to reduce flakiness #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 2 commits into from
Jul 7, 2021
Merged

chore: increase wait time for custom metric to reduce flakiness #6268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d446c1
chore: increase wait time for custom metric to reduce flakiness
parthea Jul 7, 2021
3dd42ec
Merge branch 'master' into increase-wait-time-for-custom-metric
leahecole Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions monitoring/api/v3/api-client/custom_metric_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ def custom_metric(client):
custom_metric_descriptor = create_custom_metric(
client, PROJECT_RESOURCE, METRIC_RESOURCE, METRIC_KIND)

# wait until metric has been created, use the get call to wait until
# a response comes back with the new metric with 10 retries.
# Wait up to 50 seconds until metric has been created. Use the get call
# to wait until a response comes back with the new metric with 10 retries.
custom_metric = None
retry_count = 0
while not custom_metric and retry_count < 10:
time.sleep(1)
time.sleep(5)
retry_count += 1
custom_metric = get_custom_metric(
client, PROJECT_RESOURCE, METRIC_RESOURCE)
Expand Down