Skip to content

testing(data-science-onramp): add debug output #5343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 4 commits into from
Feb 9, 2021
Merged

testing(data-science-onramp): add debug output #5343

gcf-merge-on-green merged 4 commits into from
Feb 9, 2021

Conversation

@tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Feb 8, 2021

fixes #5312

It won't fix the issue, but will allow us to debug better.

testing(data-science-onramp): add debug output
633de8f 
fixes GoogleCloudPlatform#5312

It won't fix the issue, but will allow us to debug better.
@tmatsuo tmatsuo requested review from a team, bradmiro and leahecole as code owners February 8, 2021 19:33
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Feb 8, 2021

The debug output for the success case:

df:               tripduration                starttime  ... gender  customer_plan                                                                                 
0                    778 s  2018-05-31T23:59:59.606  ...   MALE            NaN                                                                                     
1                12.45 min  2018-05-31T23:59:59.386  ...      m            NaN                                                                                     
2    0.13805555555555554 h  2018-05-31T23:59:51.083  ...   MALE            NaN                                                                                     
3                      NaN  2018-05-31T23:59:48.001  ...   MALE            NaN                                                                                     
4    0.13416666666666666 h  2018-05-31T23:59:45.677  ...      F            NaN                                                                                     
..                     ...                      ...  ...    ...            ...                                                                                     
95                   511 s  2018-05-31T23:54:28.590  ...      m            NaN                                                                                     
96                   780 s  2018-05-31T23:54:23.967  ...      m            NaN                                                                                     
97  16.016666666666666 min  2018-05-31T23:54:19.876  ...      U            NaN                                                                                     
98                   824 s  2018-05-31T23:54:08.100  ...      f            NaN                                                                                     
99                   195 s  2018-05-31T23:54:07.112  ...   male            NaN                                                                                     
                                                                                                                                                                   
[100 rows x 16 columns]                                                                                                                                            
job_config: <google.cloud.bigquery.job.load.LoadJobConfig object at 0x7f971b4affd0>

@tmatsuo tmatsuo mentioned this pull request Feb 9, 2021
Closed
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1078b51 into GoogleCloudPlatform:master Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradmiro bradmiro bradmiro approved these changes

@leahecole leahecole Awaiting requested review from leahecole

+1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@busunkim96 busunkim96

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

data-science-onramp.data-cleaning.clean_test: test_clean failed

3 participants

@tmatsuo @busunkim96 @bradmiro