Skip to content

testing(videointelligence): retry harder upon 409s #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
engelke merged 1 commit into from
Jul 23, 2020
Merged

testing(videointelligence): retry harder upon 409s #4361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions video/cloud-client/analyze/beta_snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
import os
import uuid

import backoff
from google.api_core.exceptions import Conflict
from google.cloud import storage
import pytest
from six.moves.urllib.request import urlopen
Expand Down Expand Up @@ -59,8 +61,13 @@ def bucket():

yield bucket

# Teardown.
bucket.delete(force=True)
# Teardown. We're occasionally seeing 409 conflict errors.
# Retrying upon 409s.
@backoff.on_exception(backoff.expo, Conflict, max_time=120)
def delete_bucket():
bucket.delete(force=True)

delete_bucket()


@pytest.mark.slow
Expand Down
3 changes: 2 additions & 1 deletion video/cloud-client/analyze/requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
backoff==1.10.0
pytest==5.4.3
flaky==3.7.0
flaky==3.7.0