Skip to content

testing: reliablly fetch gpg keys #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmatsuo merged 2 commits into from
Jun 26, 2020
Merged

testing: reliablly fetch gpg keys #4171

tmatsuo merged 2 commits into from
Jun 26, 2020

Conversation

@tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jun 25, 2020 •
edited
Loading

fixes #4162
fixes #4173

Also copied the latest trampoline_v2.sh, which suppress docker build logs on CI systems.

@tmatsuo tmatsuo requested review from busunkim96 and kurtisvg June 25, 2020 22:14
@tmatsuo tmatsuo requested a review from a team as a code owner June 25, 2020 22:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jun 25, 2020

tables/automl seems like a deterministic failure. #4172 filed.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jun 26, 2020 •
edited
Loading

vision/automl also seems like a deterministic failure. #4173

@tmatsuo tmatsuo force-pushed the reliable-docker-build branch from 42cad39 to cb545dc Compare June 26, 2020 01:00
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jun 26, 2020

I fixed the test in vision/automl. It was because of the environment variable name change in trampoline_v2.sh.

For tables/automl, I don't think it's related to this change. It also fails locally now.

@tmatsuo tmatsuo merged commit 5447190 into GoogleCloudPlatform:master Jun 26, 2020
@tmatsuo tmatsuo deleted the reliable-docker-build branch June 26, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@sirtorry sirtorry Awaiting requested review from sirtorry

@telpirion telpirion Awaiting requested review from telpirion

1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crwilcox crwilcox

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vision/autlml test fails with Connection reset by peer testing: unreliable gpg --recv-keys command

4 participants

@tmatsuo @kurtisvg @crwilcox @googlebot