Move sample using appengine images to this repository, add tests. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Can you check whether the resize() is called once?
Contributor
Author
|
@tmatsuo Updated with assert. |
Contributor
There was a problem hiding this comment.
Can you also test the success case?
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to generate a webapp2(webob) Request post object with multipart form data to include the image. Do you know?
Contributor
There was a problem hiding this comment.
Maybe you can just add an entity in datastore and call /img?img_id=123
What do you think?
Contributor
Author
There was a problem hiding this comment.
I'll try it out.
Contributor
Author
|
Get image positive test case is in now. |
Contributor
|
LGTM |
jeffmendoza
force-pushed
the
jlm/appengine-images
branch
from
b110e31 to
0cd2032
Compare
Contributor
Author
|
Squashed. |
8 tasks
8 tasks
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently here: https://github.com/GoogleCloudPlatform/appengine-images-guestbook-python
From here: https://cloud.google.com/appengine/docs/python/images/usingimages