[jobs] testing: add smaller tries to eventually_consistent.call #3317
Conversation
googlebot
added
the
cla: yes
|
|
||
| def test_auto_complete_sample(company_name, capsys): | ||
| @eventually_consistent.call | ||
| @eventually_consistent.call(tries=5) |
There was a problem hiding this comment.
Can we switch to flaky or retry over eventually_consistent ?
There was a problem hiding this comment.
@kurtisvg Thanks for the comment. To be honest, we have different opinions.
I think eventually_consistent has some benefit. It gives semantics.
It marks the tests as eventually consistent, which means it is a correct thing to retry.
I quite don't like to use flaky or retry for eventually consistent tests, because we can not distinguish eventually consistent tests from usual flakes.
Also, it is a great shortcut for eventually consistent issues with exponential back off. There's no need for defining helper callback.
So, for eventually consistent tests, I strongly want to stick with eventually_consistent.
There was a problem hiding this comment.
So, if we ultimately decide to eliminate gcp-devrel-py-tools, I'll replace eventually_consistent with retrying. However, I'll stick to eventally_consistent in this PR.
Can you file an issue for eliminating gcp-devrel-py-tools so that we can discuss further there?
|
The error: AssertionError: assert None
It seems like the test is failing correctly? The API response seems different from usual one. |
|
Filed: #3318 It passes 100 times locally. I'd just re-run the test for now. |
|
We decided to remove gcp-devrel-py-tools from the repo, closing. |
3 participants
fixes #3316
followup on #3278