Skip to content

Logging: remove extraneous GCP_PROJECT env var #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ace-n merged 1 commit into from
Jun 14, 2019
Merged

Logging: remove extraneous GCP_PROJECT env var #2223

ace-n merged 1 commit into from
Jun 14, 2019

Conversation

@ace-n
Copy link

@ace-n ace-n commented Jun 14, 2019

Fixes #2204

@ace-n ace-n requested a review from engelke June 14, 2019 19:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@ace-n ace-n mentioned this pull request Jun 14, 2019
Closed
engelke
engelke approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n ace-n merged commit 1ac7d42 into master Jun 14, 2019
@ace-n ace-n deleted the fix-2204 branch June 14, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cloud functions logging example possible typo

3 participants

@ace-n @engelke @googlebot