Skip to content

fix: only use print statement for logging sample #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
grant merged 1 commit into from
Mar 1, 2019
Merged

fix: only use print statement for logging sample #2025

grant merged 1 commit into from
Mar 1, 2019

Conversation

@grant
Copy link
Contributor

@grant grant commented Mar 1, 2019

No description provided.

@grant grant requested a review from ace-n March 1, 2019 18:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2019
ace-n
ace-n approved these changes Mar 1, 2019
View reviewed changes
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant grant merged commit 92944a6 into master Mar 1, 2019
@grant grant deleted the grant-log branch March 1, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ace-n ace-n ace-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grant @ace-n @googlebot