Skip to content

[Asset] Test: fix bucket clean up logic. #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gguuss merged 2 commits into from
Nov 16, 2018
+4 −4
Merged

[Asset] Test: fix bucket clean up logic. #1845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f841d67
[Asset] Test: fix bucket clean up logic.
peter-zheng-g Nov 15, 2018
034e132
Merge branch 'master' into master
gguuss Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions asset/cloud-client/quickstart_exportassets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@ def storage_client():

@pytest.fixture(scope='module')
def asset_bucket(storage_client):
storage_client.create_bucket(BUCKET)
bucket = storage_client.create_bucket(BUCKET)

yield BUCKET

try:
storage_client.delete_bucket(BUCKET)
bucket.delete(force=True)
except Exception as e:
print('Failed to delete bucket{}'.format(BUCKET))
raise e

yield BUCKET


def test_export_assets(asset_bucket, capsys):
dump_file_path = 'gs://{}/assets-dump.txt'.format(asset_bucket)
Expand Down