Skip to content

Conversation

@BigBlackWolf
Copy link

@BigBlackWolf BigBlackWolf commented Apr 8, 2024

Description

Fixes #9505
Samples haven't reflect, which exact import is needed to make it working. Refactoring to make it more precise

@google-cla
Copy link

google-cla bot commented Apr 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dialogflow Issues related to the Dialogflow API. labels Apr 8, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2024
@m-strzelczyk m-strzelczyk self-assigned this Apr 24, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2024
@BigBlackWolf BigBlackWolf force-pushed the refactor_dialogflow_imports branch from 04c96b1 to 59f8880 Compare April 25, 2024 09:06
@BigBlackWolf BigBlackWolf marked this pull request as ready for review April 25, 2024 09:07
@BigBlackWolf BigBlackWolf requested review from a team as code owners April 25, 2024 09:07
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@BigBlackWolf BigBlackWolf added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@m-strzelczyk
Copy link
Contributor

To unlock the 3.12 build, we need to update pyaudio to 0.2.14. Please do that and we should be good.

@BigBlackWolf BigBlackWolf force-pushed the refactor_dialogflow_imports branch from 59f8880 to 95c7041 Compare April 25, 2024 12:12
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@BigBlackWolf BigBlackWolf force-pushed the refactor_dialogflow_imports branch from 84e5ea2 to c392305 Compare April 25, 2024 12:20
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2024
@BigBlackWolf BigBlackWolf merged commit a6ac419 into main Apr 25, 2024
@BigBlackWolf BigBlackWolf deleted the refactor_dialogflow_imports branch April 25, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dialogflow Issues related to the Dialogflow API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor dialogflow participant_management.py to have one sample per file

3 participants