Video v1beta2 #1088
Video v1beta2 #1088
Conversation
googlebot
added
the
cla: yes
|
LGTM, but please get travis to pass. Ping me when it's ready to merge. |
|
Sorry should have pointed it out before you review it, there are three other functions (and the tests) that need to be updated. I will ping when the full PR is ready. |
|
Do not merge until client library published and tested. |
There was a problem hiding this comment.
Nit: should the i be lower case in EXPLiCIT?
There was a problem hiding this comment.
This seems like a pretty long snippet, is that intended ?
There was a problem hiding this comment.
Yes indeed - we often group the basic use cases of different methods into one script.
There was a problem hiding this comment.
We're sure the same video still works for these apparently different analyses?
There was a problem hiding this comment.
this was a rebranding of save_search_detection --> explicit_content_detection.
There was a problem hiding this comment.
Oh, I thought the "safe search" analysis was "is this safe?", the inverse of the "explicit content analysis". If it's that confusing, no wonder they rebranded it.
There was a problem hiding this comment.
yeah indeed it was confusing - safe_search_detection returned things which are not safe, for the user to filter out portions of the video, for example.
video/cloud-client/faces/faces.py
Outdated
There was a problem hiding this comment.
Should this be "start_time_offset.nanos"?
There was a problem hiding this comment.
good catch, thanks! i will scan through the other files and correct them.
video/cloud-client/labels/labels.py
Outdated
There was a problem hiding this comment.
same here, this should be start_time_offset
There was a problem hiding this comment.
As above. Might be worth making an offset_to_seconds helper function?
There was a problem hiding this comment.
that would make a lot of sense, but since we include code snippets in the devsite, refactoring out a helper function means that the user cannot use the code copied off the devsite unless they also locate and copy the helper functions.
dizcology
force-pushed
the
video_v1beta2
branch
from
7c74526 to
64fcf6d
Compare
|
tests passed against the updated client library. |
6 participants
This PR updates the sample codes to support video intelligence v1beta2.