Skip to content

Update Cleanup DAG #10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafalbiegacz merged 2 commits into from
Oct 18, 2023
Merged

Update Cleanup DAG #10771

rafalbiegacz merged 2 commits into from
Oct 18, 2023

Conversation

@apilaskowski
Copy link
Contributor

@apilaskowski apilaskowski commented Oct 17, 2023 •
edited
Loading

Resolving issue #10772

@apilaskowski apilaskowski requested review from a team as code owners October 17, 2023 14:32
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Oct 17, 2023
@apilaskowski
Copy link
Contributor Author

apilaskowski commented Oct 17, 2023

#10772

@apilaskowski
Update airflow_db_cleanup.py
12ce687 
Missing empty line at the end.
@apilaskowski
Copy link
Contributor Author

apilaskowski commented Oct 17, 2023

I tested this change with Cloud Composer environment having Airflow 2.6.3 and everything passed correctly.

@leahecole leahecole assigned leahecole and unassigned grayside Oct 17, 2023
@apilaskowski apilaskowski mentioned this pull request Oct 17, 2023
Merged
@apilaskowski
Copy link
Contributor Author

apilaskowski commented Oct 18, 2023

@leahecole is there something that I should do to unblock this? So it can be released?

@leahecole
Copy link
Collaborator

leahecole commented Oct 18, 2023

Hi - I was waiting to also be able to test on 2.6.3 but I'm not seeing it in the console yet. If you've tested it though, I supposed LGTM

@leahecole
Copy link
Collaborator

leahecole commented Oct 18, 2023

@apilaskowski you'll need one more reviewer - @rafalbiegacz has permissions

@apilaskowski
Copy link
Contributor Author

apilaskowski commented Oct 18, 2023 •
edited
Loading

2.6.3 is not released yet.
I was able to test it in Composer, as I have access to development environments.

@rafalbiegacz rafalbiegacz self-requested a review October 18, 2023 14:58
@apilaskowski
Copy link
Contributor Author

apilaskowski commented Oct 18, 2023

I also tested on 2.5.3, which should work with old logic.

@apilaskowski
Copy link
Contributor Author

apilaskowski commented Oct 18, 2023

@leahecole as you can see @rafalbiegacz tried, but it didn't work, so he is not an owner here. Whom should I ask for that?

@rafalbiegacz rafalbiegacz merged commit ef6bca5 into GoogleCloudPlatform:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecole leahecole leahecole approved these changes

@rafalbiegacz rafalbiegacz rafalbiegacz approved these changes

Assignees

@leahecole leahecole

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apilaskowski @leahecole @rafalbiegacz @grayside