Skip to content

Add region tags for authentication-users sample #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fhinkel merged 5 commits into from
Sep 12, 2019
Merged

Add region tags for authentication-users sample #336

fhinkel merged 5 commits into from
Sep 12, 2019

Conversation

@fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Sep 11, 2019 •
edited
Loading

Drive-by fix: Run linter. We didn't run the linter when we merged this, because we merged into the old branch steps instead of master, but CI runs on master.

@fhinkel fhinkel requested a review from engelke September 11, 2019 23:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 11, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 12, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 12, 2019
@fhinkel fhinkel force-pushed the auth-add-region-tags branch from e225b08 to e2b418a Compare September 12, 2019 00:49
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 12, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 12, 2019
engelke
engelke approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhinkel fhinkel merged commit 7e61f13 into master Sep 12, 2019
@fhinkel fhinkel deleted the auth-add-region-tags branch September 12, 2019 01:49
This was referenced Nov 28, 2023
Open
Open
This was referenced Dec 14, 2023
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@engelke engelke engelke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fhinkel @engelke @googlebot @kokoro-team