Skip to content

connect-datastore 'kind' configured incorrectly #314

@thebrengun

Description

@thebrengun

In app.js in 4-auth, 5-logging, 6-pubsub, and 7-gce the configuration object {kind: 'express-sessions'} is incorrectly passed into the Datastore constructor. I believe it should be passed to the DatastoreStore constructor alongside the dataset key. This fails silently and works anyways because within the connect-datastore module kind is set to 'Session' if no configuration is found. So I propose this:

store: new DatastoreStore({
  dataset: new Datastore({kind: 'express-sessions'}),
}),

Be changed to this:

store: new DatastoreStore({
  dataset: new Datastore(),
  kind: 'express-sessions',
}),

wherever it occurs. I can submit a pull request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    🚨This issue needs some love.triage meI really want to be triaged.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions