-
Notifications
You must be signed in to change notification settings - Fork 380
Closed
Labels
🚨This issue needs some love.This issue needs some love.triage meI really want to be triaged.I really want to be triaged.
Description
In app.js in 4-auth, 5-logging, 6-pubsub, and 7-gce the configuration object {kind: 'express-sessions'} is incorrectly passed into the Datastore constructor. I believe it should be passed to the DatastoreStore constructor alongside the dataset key. This fails silently and works anyways because within the connect-datastore module kind is set to 'Session' if no configuration is found. So I propose this:
store: new DatastoreStore({
dataset: new Datastore({kind: 'express-sessions'}),
}),
Be changed to this:
store: new DatastoreStore({
dataset: new Datastore(),
kind: 'express-sessions',
}),
wherever it occurs. I can submit a pull request.
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.triage meI really want to be triaged.I really want to be triaged.