Skip to content

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Oct 9, 2018

Do not merge until tests are added (blocked on #753)

@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 9, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2018
@ace-n ace-n changed the title [WIP] GCF Analytics GCF Analytics Oct 9, 2018
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 10, 2018
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment from googlebot Oct 10, 2018
@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 10, 2018
@ace-n
Copy link
Contributor Author

ace-n commented Oct 10, 2018

@crwilcox can you review the test as well?

@ace-n ace-n added needs review and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 12, 2018
@ace-n ace-n merged commit bbb6f74 into master Oct 16, 2018
@ace-n ace-n deleted the gcf-analytics branch October 16, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants