Skip to content

Fix failing tests #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ace-n merged 2 commits into from
Jul 12, 2018
Merged

Fix failing tests #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0fa9ac
Fix failing tests, take 1
Jul 9, 2018
95c46f6
Take 2
Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .kokoro/appengine/cloudsql-postgresql.cfg
View file
Open in desktop

This file was deleted.

14 changes: 13 additions & 1 deletion .kokoro/appengine/pubsub.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,16 @@ env_vars: {
env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/nodejs-docs-samples/.kokoro/build.sh"
}
}

# Set the Pub/Sub topic to use
env_vars: {
key: "PUBSUB_TOPIC"
value: "integration-tests-instance"
}

# Set the Pub/Sub verification token to use
env_vars: {
key: "PUBSUB_VERIFICATION_TOKEN"
value: "123456abcdef"
}
8 changes: 7 additions & 1 deletion .kokoro/cloudtasks.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,10 @@ env_vars: {
env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/nodejs-docs-samples/.kokoro/build.sh"
}
}

# Set the task queue to use
env_vars: {
key: "GCP_QUEUE"
value: "nodejs-test-queue-do-not-delete"
}
5 changes: 3 additions & 2 deletions appengine/cloudsql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@
"prompt": "1.0.0"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "2.2.5",
"ava": "0.25.0"
"@google-cloud/nodejs-repo-tools": "2.3.0",
"ava": "0.25.0",
"semistandard": "^12.0.1"
},
"cloud-repo-tools": {
"requiresKeyFile": true,
Expand Down
7 changes: 4 additions & 3 deletions containerengine/hello-world/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@
},
"scripts": {
"start": "node server.js",
"lint": "samples lint",
"lint": "repo-tools lint",
"pretest": "npm run lint",
"system-test": "samples test app",
"system-test": "repo-tools test app -- server.js",
"test": "npm run system-test"
},
"dependencies": {},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "1.4.17"
"@google-cloud/nodejs-repo-tools": "^2.3.0",
"semistandard": "^12.0.1"
},
"cloud-repo-tools": {
"test": {
Expand Down
1 change: 1 addition & 0 deletions endpoints/getting-started/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"@google-cloud/nodejs-repo-tools": "^2.3.0",
"ava": "0.25.0",
"proxyquire": "2.0.0",
"semistandard": "^12.0.1",
"sinon": "4.4.2",
"supertest": "3.0.0"
}
Expand Down
7 changes: 4 additions & 3 deletions language/slackbot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,20 @@
"node": ">=4.3.2"
},
"scripts": {
"lint": "samples lint",
"lint": "repo-tools lint",
"pretest": "npm run lint",
"test": "samples test run --cmd ava -- -T 20s --verbose system-test/*.test.js"
"test": "repo-tools test run --cmd ava -- -T 20s --verbose system-test/*.test.js"
},
"dependencies": {
"@google-cloud/language": "0.11.0",
"botkit": "0.5.7",
"sqlite3": "3.1.9"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "1.4.17",
"@google-cloud/nodejs-repo-tools": "2.3.0",
"ava": "0.21.0",
"proxyquire": "1.8.0",
"semistandard": "^12.0.1",
"sinon": "3.2.0"
}
}