Skip to content

GCF Hello World: GCS sample tweaks #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ace-n merged 3 commits into from
Dec 14, 2018
Merged

GCF Hello World: GCS sample tweaks #1024

ace-n merged 3 commits into from
Dec 14, 2018

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Dec 14, 2018 •
edited
Loading

  1. Update @google-cloud/storage library
  2. Add (system) test for getSignedUrl
  3. Fix lint (semistandard)

@ace-n ace-n requested a review from fhinkel December 14, 2018 00:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2018
@ace-n ace-n merged commit 7c2b12d into master Dec 14, 2018
@ace-n ace-n deleted the fix-b117832179 branch December 14, 2018 19:58
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ace-n @fhinkel @googlebot