-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
The tests for the Manual Logging sample are flaky.
1. Flaky Test Failures
An example build log indicates assertion failures around structured log properties, indicating the logs retrieved for testing may not be correct for the test.
Potential avenues to check:
- Is the log filter narrow enough to exclude unrelated platform entries?
- Could there be a problem introduced by concurrent testing of the same PR? (See problem 2)
2. Service under test does not exist to be deleted
An example build log indicates the github-sourced runner script used to manage the sample's end-to-end tests reaches the cleanup stage and then cannot find the service to delete. Oddly, the tests just completed successfully.
Potential avenues to check:
- Is this PR being simultaneously tested in two different builds, such that the timing for service cleanup matches almost to the second?
- Could the cleanup function be called twice, succeeding the first time, but failing the second? In this case, the bash xtrace mode would somehow have to fail on one execution.
fhinkel
Metadata
Metadata
Assignees
Labels
type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.