Skip to content

docs: In bigtable fraud demo, change "demographics" wording #7336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
averikitsch merged 3 commits into from
Oct 25, 2022
Merged

docs: In bigtable fraud demo, change "demographics" wording #7336

averikitsch merged 3 commits into from
Oct 25, 2022

Conversation

@billyjacobson
Copy link
Member

@billyjacobson billyjacobson commented Oct 10, 2022 •
edited
Loading

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 10, 2022
@kweinmeister kweinmeister added the api: bigtable Issues related to the Bigtable API. label Oct 18, 2022
@billyjacobson billyjacobson marked this pull request as ready for review October 24, 2022 19:34
@billyjacobson billyjacobson requested review from a team and yoshi-approver as code owners October 24, 2022 19:34
@ikettaneh
Copy link
Contributor

ikettaneh commented Oct 25, 2022

https://screenshot.googleplex.com/3JJgVtVoGY8GFKi
The readme file seems to be broken

@billyjacobson billyjacobson added the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 25, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 25, 2022
@billyjacobson billyjacobson changed the title docs: In bigtable fraud demo, change "demographics" to be "customer p… docs: In bigtable fraud demo, change "demographics" wording Oct 25, 2022
@averikitsch averikitsch merged commit bfc80a2 into main Oct 25, 2022
@averikitsch averikitsch deleted the fraud-demo branch October 25, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

+1 more reviewer

@ikettaneh ikettaneh ikettaneh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danieljbruce danieljbruce

Labels

api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@billyjacobson @ikettaneh @averikitsch @danieljbruce @kweinmeister