Skip to content

Conversation

@Mukamik
Copy link
Contributor

@Mukamik Mukamik commented May 11, 2022

Since most users looking to access bundled services will want to use the App Engine APIs directly, I think it makes sense to include steps to add the required dependency.

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

Since most users looking to access bundled services will want to use the App Engine APIs directly, I think it makes sense to include steps to add the required dependency.
@Mukamik Mukamik requested review from a team and yoshi-approver as code owners May 11, 2022 23:46
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 11, 2022
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might wish to mention that they may wish to remove the old api library.

@lesv lesv assigned averikitsch and unassigned Shabirmean May 12, 2022
@lesv lesv added kokoro:force-run Add this label to force Kokoro to re-run the tests. snippet-bot:force-run Force snippet-bot runs its logic labels May 12, 2022
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label May 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2022
@averikitsch averikitsch merged commit 6f8408f into GoogleCloudPlatform:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants