Skip to content

Conversation

@Sita04
Copy link
Contributor

@Sita04 Sita04 commented Apr 27, 2022

Added parallel testing support for samples with mvn surefire and JUnit jupiter.

@Sita04 Sita04 requested review from a team and yoshi-approver as code owners April 27, 2022 15:06
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 27, 2022
@Sita04 Sita04 requested a review from kurtisvg April 27, 2022 15:09
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
Copy link
Contributor

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM! Left some nit comments.

Tagging @lesv since I am still a a shadow reviewer. I see @kurtisvg is already in the reviewer list. So removing les

@kurtisvg kurtisvg force-pushed the compute-samples-parallel-testing branch from 472c63d to bdb19f9 Compare April 29, 2022 21:10
@Sita04 Sita04 requested a review from Shabirmean May 11, 2022 11:30
@Sita04 Sita04 merged commit e9dec4f into main May 13, 2022
@Sita04 Sita04 deleted the compute-samples-parallel-testing branch May 13, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants