Skip to content

Disable some shellchecks. #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesv merged 5 commits into from
Mar 6, 2017
Merged

Disable some shellchecks. #542

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d549a57
Disable some shellchecks.
Mar 4, 2017
a21d07c
Merge branch 'master' into shellcheck
lesv Mar 5, 2017
e78d948
Merge branch 'master' into shellcheck
lesv Mar 5, 2017
15b3701
Merge branch 'master' into shellcheck
lesv Mar 6, 2017
58f630b
Disable some shellchecks.
Mar 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jenkins.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ shopt -s globstar

app_version=""

# shellcheck disable=SC2120
delete_app_version() {
if [ -n "${app_version}" ] || [ $# -gt 0 ]; then
yes | gcloud --project="${GOOGLE_PROJECT_ID}" \
Expand All @@ -29,7 +30,7 @@ handle_error() {
errcode=$? # Remember the error code so we can exit with it after cleanup

# Clean up
delete_app_version
delete_app_version # shellcheck disable=SC2119

exit ${errcode}
}
Expand All @@ -39,7 +40,7 @@ trap handle_error ERR
shellcheck ./**/*.sh

# Find all jenkins.sh's and run them.
find . -mindepth 2 -maxdepth 5 -name jenkins.sh -type f | while read path; do
find . -mindepth 2 -maxdepth 5 -name jenkins.sh -type f | while read -r path; do
dir="${path%/jenkins.sh}"
app_version="jenkins-${dir//[^a-z]/}"
(
Expand Down