Skip to content

Conversation

@kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Nov 7, 2018

Same as #1231, but for PostgreSQL.

Corrects some of the region tags to be MySQL-specific (these are pretty much the same for Java, but vary in some languages so separate region tags are needed).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2018
@kurtisvg kurtisvg requested a review from lesv November 7, 2018 22:54
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I hate that you have to specify things twice. That never goes well for me.
    (The alternative however is way too convoluted).
  2. If I haven't mentioned it before, voting / counting apps can be problematic at times.

That said it all looks very nice.

@kurtisvg kurtisvg merged commit 3d6f7be into master Nov 8, 2018
@kurtisvg kurtisvg deleted the postgres-conn branch November 8, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants