Remove unused dependency region tags and update used region tags #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
nnegrey
previously approved these changes
Aug 27, 2018
Contributor
nnegrey
left a comment
nnegrey
left a comment
There was a problem hiding this comment.
LGTM
(interesting how some are used and others aren't)
nnegrey
added
the
do not merge
tswast
previously approved these changes
Aug 28, 2018
alixhami
force-pushed
the
update-dependency-tags
branch
from
5e63c84 to
97329cd
Compare
Contributor
Author
|
I updated my approach with the unused region tags. Rather than deleting them, I gave them names that use the standard globally unique naming conventions, so that we avoid people adding the plain "dependencies" region tag in the future. |
alixhami
force-pushed
the
update-dependency-tags
branch
from
97329cd to
4669400
Compare
tswast
previously approved these changes
Aug 29, 2018
nnegrey
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
alixhami
changed the title
alixhami
removed
the
do not merge
alixhami
force-pushed
the
update-dependency-tags
branch
from
4669400 to
2f10893
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal with sample region tags is to have a globally unique tag for each sample. The "dependencies" tag is used throughout the java-docs-samples repo, which goes against best practices. This PR accomplishes the following:
Note that this PR does not include all products, only ones that I am responsible for adding to the sample tracker. Others will be performing this update for the remaining products.