-
Notifications
You must be signed in to change notification settings - Fork 168
refactor: use cesdk #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use cesdk #391
Conversation
Signed-off-by: Grant Timmerman <[email protected]>
Signed-off-by: Grant Timmerman <[email protected]>
Signed-off-by: Grant Timmerman <[email protected]>
I actually don't think we should take a dependency on the CESDK for this. It drags in transitive dependencies that aren't actually used at run time. |
It does have two dependencies, true. But they are small and not unused. |
Thanks for the comment @matthewrobertson . While I understand that it's generally beneficial to reduce dependencies across our libraries, there are reasons why I believe now is a good time to add the SDK here. (this PR, including the CESDK in the FF has been a couple years in the process 😅) Here are example specific details why we should add the SDK the the FF (and why we have done so for other FFs):
@lance and I have made a good effort in reducing dependencies in the past. I've evaluated all deps including In this case, I believe this PR should be reviewed as it would be beneficial to the FF authors and users. |
Signed-off-by: Grant Timmerman <[email protected]>
Per discussion with Matt, letting Annie review as a 3rd person. I think there will be benefit for us not having to maintain CloudEvent-specific / vendor-agnostic logic within this library. We'll work with the CloudEvents community across our FFs to support the ideal devX. |
Keeping record here. Matt wanted to add some comments in and wasn't able to with this PR before it was merged. We talked about this PR last Friday and some more today where we have a review in the quick roll-back roll-forward PR. Proceeding with the roll-forward as discussed. |
* Revert "Revert "refactor: use cesdk (#391)" (#399)" This reverts commit ad75658. * ci: run doc generator Signed-off-by: Grant Timmerman <[email protected]> * ci: gen docs Signed-off-by: Grant Timmerman <[email protected]> * refactor: minor import refactoring Signed-off-by: Grant Timmerman <[email protected]> * ci: fix docs Signed-off-by: Grant Timmerman <[email protected]>
Refactors the Node FF to use interfaces from the CESDK. No runtime change.
CC: @lance
Fixes: #140