Require "remove_tag_prefix" to be specified in configs. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this option specified, the output of the plugin will be fed back to itself, causing infinite recursion and errors that can be hard to understand. This was initially reported in GoogleCloudPlatform#9 and this solution was initially suggested by thomasschickinger.
igorpeshansky
suggested changes
Jun 17, 2020
|
Thanks for the review - addressed the comments. |
igorpeshansky
suggested changes
Jun 17, 2020
Use multiline string literal instead of \n for readability. Verify that leaving out remove_tag_prefix generates the right error.
|
Thanks for the suggestions - they all make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this option specified, the output of the plugin will be fed back to
itself, causing infinite recursion and errors that can be hard to understand.
This was initially reported in #9 and this solution was initially
suggested by thomasschickinger.
Fixes #9.