Add documentation for new language support implication. #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkohen
reviewed
Dec 28, 2018
README.rdoc
Outdated
|
|
||
| New language support requires adding new rules in this gem. But that alone only | ||
| help bundle multi-line messages into one line. Logging backend will need to | ||
| support this new exception as well for proper recognization down the pipeline. |
There was a problem hiding this comment.
I think a more useful message would tell the reader what to do. It's not clear to me how one gets the Logging backend to support this, or if that's even something a curious reader will be able to do.
Contributor
Author
There was a problem hiding this comment.
Added some instruction on how to file feautre request support case. Also added an example (Dart language support) for clarification.
qingling128
force-pushed
the
lingshi-new-lang
branch
from
ed8e3aa to
5082141
Compare
jkohen
approved these changes
Dec 28, 2018
jkschulz
approved these changes
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.