Fix file permissions instead of just checking them.

[mobilesfinks]

i need this fix for issue #32

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[googlebot]

CLAs look good, thanks!

[igorpeshansky]

LGTM

[qingling128]

This flat_map seems to be an no-op? It's equivalent to:

  files = [
    'lib/fluent/plugin/exception_detector.rb',
    'lib/fluent/plugin/out_detect_exceptions.rb'
  ]

Right?

[igorpeshansky]

It's a good pattern to have in case we decide to add wildcards to the list of files (and it's consistent with fluent-plugin-google-cloud/Rakefile). But I'll leave it up to you.

[qingling128]

If we want a wild card, we can change it to:

  files = [
    'lib/fluent/plugin/*.rb'
  ].flat_map do |file|
    file.include?('*') ? Dir.glob(file) : [file]
  end

The way it is right now is a bit confusing to read.

[igorpeshansky]

Yeah, the gemspec uses a wildcard to select the files to package, so your suggestion makes sense. Let's go with that, then.

[mobilesfinks]

Changed

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[googlebot]

CLAs look good, thanks!

[qingling128]

LGTM

[tomelliff]

This doesn't appear to be working in 0.0.11:

/ # gem list

*** LOCAL GEMS ***

cool.io (1.5.3)
dig_rb (1.0.1)
elasticsearch (6.0.2)
elasticsearch-api (6.0.2)
elasticsearch-transport (6.0.2)
excon (0.62.0)
faraday (0.15.1)
fluent-plugin-detect-exceptions (0.0.11)
fluent-plugin-elasticsearch (2.10.1)
fluentd (1.1.3)
http_parser.rb (0.6.0)
json (2.1.0)
msgpack (1.2.4)
multi_json (1.13.1)
multipart-post (2.0.0)
oj (3.3.10)
openssl (default: 2.0.7)
psych (default: 2.2.2)
serverengine (2.0.6)
sigdump (0.2.4)
strptime (0.2.3)
thread_safe (0.3.6)
tzinfo (1.2.5)
tzinfo-data (1.2018.4)
yajl-ruby (1.3.1)
/ # ls -la /usr/lib/ruby/gems/2.4.0/gems/fluent-plugin-detect-exceptions-0.0.11/lib/fluent/plugin/
total 28
drwxr-xr-x    2 root     root          4096 May 15 17:47 .
drwxr-xr-x    3 root     root          4096 May 15 17:47 ..
-rw-r-----    1 root     root         11514 May 15 17:47 exception_detector.rb
-rw-r--r--    1 root     root          4449 May 15 17:47 out_detect_exceptions.rb