Remove unnecessary JSP initialization in EE10 #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Collaborator
|
Risky without a test, but the good news is a test is coming with the work we do on EE11, so I would wait to submit this |
ludoch
added
the
too_early_to_commit
Collaborator
|
Please, sync up, we have tests now covering this area. |
ludoch
approved these changes
Sep 29, 2025
ludoch
added
ready to pull
and removed
too_early_to_commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should keep this behavior in Jetty 12 EE8, just in case any legacy applications are including JSP jars old enough to need it.
But this is dead code in EE10 especially considering it is still using the javax version so would not work regardless. Initialization is now done though the
ServletContainerInitializerprovided in by the JSP jars.